michaeloffner

Results 48 comments of michaeloffner
trafficstars

@cfmitrah can you please solve merge conflicts here and test it

@cfmitrah the code does not work for me, can you please revisit this and redirect it to 6.0

this pull request is for the master branch, we do never coding on the master branch directly, the master branch only see merges of branches that get releases. please make...

this PR affects the loader what would make necessary for EVERY user to manually update the lucee.jar, we only make this for MAJOR updates. Lucee 4 to 5 or Lucee...

this (and similar) allowRequestTimeout( Caster.toBoolean(SystemUtil.getSystemPropOrEnvVar("lucee.enable.request.timeout", null) , true) ); need to be changed to this allowRequestTimeout( Caster.toBooleanValue(SystemUtil.getSystemPropOrEnvVar("lucee.enable.request.timeout", null) , true) ); because it makes 2 unnecessary Autoboxing/Unboxing from Boolean to...

i did not check in detail yet, do you make sure that gateway threads still are NEVER running in a request timeout. this is very important.

i try to keep the amount of methods as low as possible, the following methods seem not necessary getRequestHasTimedOut,setRequestHasTimedOut you can use getTimeoutStackTrace()!=null instead.

@zspitzer what is the status on this?

we should NOT change the default log level, unless there is really a good reason for it

url,path,url is not necessary to get an extension, id and version can be sufficient. Actually id on it's own should be sufficient, when you define no version, it simply should...