Michael Gugino

FindPidByPodContainer unreliable

3

https://github.com/iovisor/kubectl-trace/blob/7fd30079cf6e00218d78500eb41786847df37fe4/pkg/procfs/procfs.go#L59 This code makes too many assumptions about what the file paths will look like. Actual mount results on my cluster look like `/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod30cea2cf_1b80_4807_abad_d81453e199c5.slice/crio-a8077b08a56c0c6e33d6716557d882ac940cb09475c50372e22e84c40d0733f2.scope` Additionally, the following agruments get passed...

Unfortunately, kubernetes.io/hostname is not reliable and this label may not match any nodes (on AWS, this can be caused by NodeName being fully qualified while kubernetes.io/hostname is not fully qualified)....

Docs should have links to working publishers and consumers

2

It's not at all clear who is using this library. Some links to relevant examples would be quite helpful.