michael faith

Results 69 comments of michael faith

This is great to hear @jamesnw. Excited to see your proposal.

@jamesnw One thing I'd mention that's worth considering, is how certain frameworks are handling this today. Since multiple types of files can be exported from a single entry point, it...

> @michaelfaith I’ve done a bit of sleuthing, and have found that Vite supports the `sass` and `style` custom conditions for resolving paths within Sass. I haven’t done an exhaustive...

I bumped into this as well, saying the template library didn't properly declare `@typescript-eslint/types`. ``` @angular-eslint/eslint-plugin-template tried to access @typescript-eslint/types, but it isn't declared in its dependencies; this makes the...

> @fabienbranchel > If you want to set the background colors, you likely want to customize the entire background and foreground palette by emulating the [mat-light-theme](https://github.com/angular/material2/blob/3352201eabcf66c23e6c2297b800828003eaf0fc/src/lib/core/theming/_theming.scss#L62) or mat-dark-theme functions with...

> Where is it even documented what the sass identifiers for the background and foreground colours are? I don't even want to customize these values, I'm just trying to work...

> Why can't we support something like: > > ``` > $core-theme: mat.define-light-theme(( > color: ( > primary: $primary, > accent: $accent, > warn: $warn, > foreground: ( > base:...

This function (and the dark theme version) is what would likely need to change, to allow for those parameters, instead of only taking defaults. https://github.com/angular/components/blob/c649f7dfca3df2cd3a47365a2930718dab4a8a09/src/material/core/theming/_theming.scss#L114-L123 Ideally it would start with...

> Does https://material.angular.io/cdk/overlay/overview meet the needs here? > > If not, what is missing? more documentation? a component that simplifies that API and adds Material Design styles? I think that...