michael faith comments

Results 387 comments of


                                            michael faith

Change Request: Replace `chalk` with Node.js' native `styleText` in v10

`util.styleText` is only marked stable starting in 22.13.0 (and 23.5.0). v20 doesn't have the api marked stable (available but not "stable"). https://nodejs.org/api/util.html#utilstyletextformat-text-options

Implement CSS custom properties

It seems this is still an issue. Has anyone found a workaround for having `var()` calls resolve to the appropriate variable value?

🚀 Feature: Bring in a require-publishConfig rule

> Perhaps it would be better for us to create two separate rules instead of one: > > * `valid-publish-config` (validates correct usage based on package scope) > * `no-redundant-publish-config`...

🚀 Feature: Bring in a require-main rule

> Looking forward to this because main field or exports will be mandatory in future nodejs https://nodejs.org/api/all.html#DEP0151 Good callout. I wonder if they've defined a timeline for when that will...

parserServices error in recent eslint v9 changes

Were you able to create a repro? Also, what parser are you using?

[Data Mode] Throwing redirect in middleware isn't short-circuiting route module loading

I noticed there was this bug fix that seems somewhat adjacent to this but in reverse for `throw`s that don't originate from `redirect`. https://github.com/remix-run/react-router/pull/14182

[Data Mode] Throwing redirect in middleware isn't short-circuiting route module loading

Thanks @brophdawg11! Appreciate the quick response 🙏 . Confirmed that adding a (no-op) loader function to our routes as a workaround does work