Michael Bynum

WNTRSimulator simulates a single timestep every time run_sim is called even if the sim_time is past the duration

1

WNTRSimulator simulates a single timestep every time run_sim is called even if the sim_time is past the duration

This is particularly an issue when turning a constant power pump off and then back on. The flow in a constant power pump should never be 0.

…alues equal to None. See #130 for some history

`None` thermal limits should be processed correctly in the variable declaration functions rather than in the functions that construct the models. This will reduce repeated code.

Reorganization

5

What does everyone think about a slight reorganization of Egret? I am thinking of the directory structure below. I have not fully flushed it out, but I think you will...

Missing else statement

3

In `egret.model_library.transmission.branch.declare_ineq_p_branch_thermal_lbub`, there is an if statement that checks if the approximation type is is `BTHETA` or `PTDF`. If so, constraints are added to limit the power flow. However, there...

We should decide if both of these functions are needed `egret.model_library.transmission.branch.declare_ineq_p_branch_thermal_bounds` and `egret.model_library.transmission.branch.declare_ineq_p_branch_thermal_lbub`

See lines 275-276 in egret/model_library/transmission/bus.py. We check to see if the load is zero. If it is not, then we subtract `m.pl[bus]` from the power balance. However, there is no...

Calculate variable from constraint differentiation mode

1

Add an option to calculate_variable_from_constraint to use different modes of differentiation in order to support external functions. ## Fixes #2542. ### Legal Acknowledgement By contributing to this software project, I...

Python Interface should release the GIL when run gets called

8

The GIL prevents other python threads from running. Releasing it when `run` is called (and grabbing it again at the end of `run`) will allow other threads to proceed while...