pyomo icon indicating copy to clipboard operation
pyomo copied to clipboard

Calculate variable from constraint differentiation mode

Open michaelbynum opened this issue 2 years ago • 1 comments

Add an option to calculate_variable_from_constraint to use different modes of differentiation in order to support external functions.

Fixes #2542.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

michaelbynum avatar Sep 28 '22 15:09 michaelbynum

Codecov Report

Base: 86.46% // Head: 86.70% // Increases project coverage by +0.24% :tada:

Coverage data is based on head (1c5b658) compared to base (aef3707). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2549      +/-   ##
==========================================
+ Coverage   86.46%   86.70%   +0.24%     
==========================================
  Files         725      725              
  Lines       80626    80633       +7     
==========================================
+ Hits        69714    69915     +201     
+ Misses      10912    10718     -194     
Flag Coverage Δ
linux 84.06% <100.00%> (+1.72%) :arrow_up:
osx 74.33% <100.00%> (+<0.01%) :arrow_up:
other 84.24% <100.00%> (+1.73%) :arrow_up:
win 81.28% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/util/calc_var_value.py 100.00% <100.00%> (ø)
pyomo/contrib/interior_point/interior_point.py 95.03% <0.00%> (+0.26%) :arrow_up:
pyomo/contrib/parmest/utils/mpi_utils.py 75.25% <0.00%> (+27.83%) :arrow_up:
...o/contrib/interior_point/linalg/mumps_interface.py 76.82% <0.00%> (+54.87%) :arrow_up:
pyomo/contrib/pynumero/linalg/mumps_interface.py 84.09% <0.00%> (+66.66%) :arrow_up:
pyomo/contrib/pynumero/examples/mumps_example.py 97.50% <0.00%> (+82.50%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 30 '22 00:09 codecov[bot]

@andrewlee94 A calc_var_kwds argument, which should be a dict of arguments to pass to calculate_variables_from_constraint, already exists in solve_strongly_connected_components! I added it because at some point I needed to send custom tolerances.

Robbybp avatar Oct 11 '22 02:10 Robbybp