Michael Bull

Results 30 comments of Michael Bull

# [Progressive Web App Checklist](https://developers.google.com/web/progressive-web-apps/checklist) ### Baseline Progressive Web App Checklist - [x] Site is served over HTTPS - [x] Pages are responsive on tablets & mobile devices - [...

I suppose this could live in a `kotlin-result-test` package or similar, which has a dependecy on the multiplatform `kotlin.test` package and also exports the functions as described in your post....

I'm not against breaking the API if it avoids such a problem. Could you explain what change you'd make and what the calling code would end up looking like? I...

I actually don't think that will be a breaking change, because if you look [here](https://github.com/michaelbull/kotlin-retry/blob/master/src/main/kotlin/com/github/michaelbull/retry/Retry.kt#L47) the call to `withContext` has a second argument which is the `block`. According to the...

I've gone ahead and made a rather significant refactoring that would be part of a v2 in 2babe2a1f91308d642b66df4646aacb9eb0dcb78. The main benefit is that it removes the burden on the caller...

Do [these](https://github.com/michaelbull/rs-api/blob/master/src/main/java/com/github/michaelbull/rs/hiscores/HiscoreTable.java#L35) not work?

Yeah doesn't look like the OSRS GE is supported, however there is documentation for it [here](https://www.reddit.com/r/2007scape/comments/3g06rq/guide_using_the_old_school_ge_page_api/). I think it would be a case of tackling [this](https://github.com/michaelbull/rs-api/blob/master/src/main/java/com/github/michaelbull/rs/ge/GrandExchange.java#L21) hardcoded URL, making it...

Thanks for the considerate response @johnwalley.

To work around this I redeclared my own responsive container by referencing rechart's [`ResponsiveContainer`](https://github.com/recharts/recharts/blob/master/src/component/ResponsiveContainer.tsx) but replacing the `ReactResizeDetector` with the [`use-resize-observer`](https://www.npmjs.com/package/@react-hook/resize-observer) hook. Here's an example below until this bug is...

Kotlin Coroutines [doesn't support mingw86](https://github.com/Kotlin/kotlinx.coroutines/issues/2157), so probably not.