Michael Bromley comments

Results 750 comments of


                                            Michael Bromley

Animation flickering with pagination

@LeleDev I think the point is that this is only an issue if you _want_ to animate the list in some way. Another approach would be to to use the...

Disqus does not show if there is ngAnimate.

Hi, thanks for the report. Unfortunately I do not have time to look into this at the moment - I am prioritizing issues in the dirPagination module (since it is...

Add ability to change asyncMode during lifetime

Hi, Thanks for the contribution. Can you outline the use-case and how to use your changes?

Pagination: Multiple instances with asynchronous data

Good point. For now I think you might be able to get around that by using a $watch on the value of each pagination's "current-page", and triggering a function when...

null ref error on ajax data

Hi, Thanks for the contribution. Could you outline the scenario that causes an error which is fixed by this?

When switching data sources dir-pagination-controls displays wrong number of results

Hi, Thanks for the detailed report. Is it possible to make a Plunker demo of this? I cannot tell from what you wrote, but are there multiple dir-paginations being used...

Added option to include the 'data' property of the state into the breadcrumb

Hi, Sorry this took a while to get back to you on. First of all, thanks for the PR. I was wondering if you could give me some example use-cases...

Vendor folder is missing angular-mocks and angular-ui-router to run unit tests

Hi, Thanks for that - actually the `vendor` folder should probably be omitted altogether from the repo, and we should instead rely on `bower install` to populate it. Looks like...

dirPaginate: Multiple Instances within directive ng-repeat

Hi, can you confirm that the `blockIndex` value is unique for each instance of your directive? The behavior you describe suggests that it may not be. Also make sure you...

ordinalDate filter: Showing a date one day earlier

Thanks for the report. I'll look into this properly when I have more time later this week, hopefully. I somewhat dread getting into the murky world of date-time manipulation in...