Michael Bromley

Results 751 comments of Michael Bromley

When the database schema does not yet exist, you can set the `dbConnectionOptions.synchronize` setting to `true` and that will cause Vendure to populate the DB schema when it bootstraps.

Hi, This is basically good and I like the `slug` lib since it is small and has zero dependencies. The main issue I see is the way it is handling...

@andriinuts Yes, if we can have the benefit of 'slug' for the western languages, and no-op for non-supported languages like Chinese, then this is a good approach.

Hi Lacey, Looking at that overide decorator, it seems to be solving a slightly different problem: how to avoid duplication of decorators on methods your are overriding. Since Vendure core...

Yes I agree this would make more sense as part of the plugin metadata. I wonder if we could do it without even adding a new "overrides" property, but by...

Yes the decorator approach is also elegant. I assume that: - It would implicitly add the `Injectable()` decorator? A bit like the current `Resolver()` decorators also implicitly makes the class...

Hi, Yes, your breakdown of the problem sounds right to me. `getServiceOverridesFromPlugins()` to get the overridden classes and pass as the providers array in the ServiceCoreModule. One issue I thought...

Hi, I just repeated the steps on a clean v2.2.3 install and could not reproduce: ``` ┌ ✨ Let's add a new feature to your Vendure project! │ ◇ Which...

Did you make any changes to the service before attempting to create the API? If you are able to reproduce this from a clean install, please tell me the _exact_...