Michael Bromley

Results 750 comments of Michael Bromley

Hi, This is by design really. TypeORM is in change of the DB schema, and will only respect column data that is registered via TypeORM decorators or metadata. In this...

I agree that validation would be useful beyond the basic type checking of GraphQL. I'd like to explore the options available for this. The class-validator lib looks like a good...

Thanks for the suggestion of ajv. I'll look into that. Another thought I just had and will note here for later: An alternative could be to rely on custom GraphQL...

Hi @driccio98, apologies for the slow reply. This is not currently planned for the next release. I've got it in the "planned" backlog but I have other higher-priority issues to...

Hi! Thanks for the report. I agree that the current behaviour is unexpected. There are 2 options here I think: 1. Enforce the non-nullability at the DB level. This would...

Note: a consideration here is that for non-relation custom fields, setting as `nullable: false` means that a `defaultValue` must be set. There's a [validation function](https://github.com/vendure-ecommerce/vendure/blob/d50d48835f62f91efd7f672e250c5e4d0c90531e/packages/core/src/entity/validate-custom-fields-config.ts#L81-L91) that enforces this at bootstrap....

Hi @Draykee, can you describe how you would like this to work? Both in terms of the UI and also the API if you have any ideas on that?

I've been thinking a bit more about this and I had an idea that could solve this in a more general way, let's call it "job triggers" So the idea...

Hi, I don't really understand what you are trying to do here - what's `order.administration`? Is this some customization of yours? Also, the `OrderService.applyCouponCode()` does not take an `order` object....

Hi, This is a good point, and I agree that they should both use the Angular hooks. This would be a breaking change so I'll mark it for the next...