michael-mclawhorn comments

Results 19 comments of


                                            michael-mclawhorn

Add support to manually remove a query cache

Is your proposal to nuke a specific query out of the cache? Because if so _cache=false should do that. Assuming you can hit the exact query.

CORS headers verification and customization

This is not a bad set of changes, but I think we may want to get out of the business of providing default cors filtering. I'll review this PR, but...

Add custom sslcontext support in fili

definitely need a change to CHANGELOG, and you should probably create an issue to link to in the changelog ticket. Should also add a test to config that this code...

Druid Loader not loading past dimension data.

Actually, the issue is that it loads the same dimension data, never moving forward.

Fix: Delivering code in production with debug features activated is security-sensitive

https://github.com/yahoo/fili/pull/1102

Preface logblock lazily grabs username for serialization

👍 Looks good. If it passes.

Requests for a nonexistent metadata identifier should return status 404

https://github.com/yahoo/fili/pull/1079

Memcached won't cache values over 20k

Make cache size configurable for Memcached clients

Parameterized metric design

@archolewa @QubitPi please rereview as you're able.

Parameterized metric design

@archolewa Did I answer all your concerns? If so, please approve.