Micael Levi L. Cavalcante

Results 443 comments of Micael Levi L. Cavalcante

I agree with the change. But since `ThrottlerStorageService` is a public API, we can't change the return type of `get storage` for now otherwise we'll introduce a breaking change Just...

Would you like to create a PR to address this issue?

> Disabling the plugin should have no impact on the build time. but the plugins are evaluated by `@nestjs/cli` when you use the `build` command. And so they should impact...

yeah, that would help a lot My only concern is that others snippets and the text itself in the page won't change accordingly, and this might confuse people.

> By default `abortOnError` will be `true` to keep the current behavior. I'd say that we should align it with the `abortOnError` of `NestFactory` instead. So if we supply `abortOnError:...

and for completeness, I'd say that we should support the same for `app.get()` errors as well. As of now, we cannot handle exceptions on them when having `abortOnError:true` (the default)

not sure if I followed this Can you please provide some code snippets to show us the API (or a suggestion of one) that you're thinking of? I have one...

that might be feasible but we'd have to change a bunch of things including `@nestjs/swagger` because the support http methods are well-defined in the enum `RequestMethod` and the `REQUEST_METHOD_MAP` internal...

not that flexible because we need to ensure that we're supporting any 3rd-party http adapter as well

Yeah, I guess we would have to choose between adding more methods that would be optional to avoid breaking changes, or making the http adapter flexible enough to support any...