Micah Snyder

Results 405 comments of Micah Snyder

**Fixed:** Updated the PR to get the unit test working. I thought they'd worked before, but perhaps I lost a code fix switching between Mac & Windows. I've also: -...

Update: The initial test `cabd_test` failure on Windows was a silly copypaste issue. I've resolved this and the `` line number issue, but now see a different failure for the...

I've figured out why the Windows tests fail. Two reasons: 1. You can't open `"/dev/null"` in Windows. Instead, open `"NUL"` (with 1 "L"). 2. Defining `_LARGEFILE_SOURCE=1` and `_FILE_OFFSET_BITS=64` does not...

Sorry about the delay on this! I never saw a notification from github, and thought you hadn't looked at it yet. I'll try to review your comments asap and update...

After rebasing to include your changes and fix up a the mspack error message stuff, and add additional improvements to the autogen.sh script, I have found that 2/3 tests pass...

> I've changed these offsets in the test files so both 32-bit I/O mode and 64-bit I/O mode get to the same code path and test the files properly. See...

Okay! I have cabextract building on mac & Windows. The tests will run on posix systems, but not on Windows because they're all shell scripts. That said, I haven't really...

@kyz Have you had a chance to give this a try? I've been meaning to figure out the reason for the encoding test failure. Will try to figure that out...

@kyz Ok I fixed the encoding test. It was an iconv detection issue. Speaking of which, I noticed that iconv detection will fail for autotools if gettext-devel isn't installed, but...

Cross-compiling should be possible with CMake as well, though I don't have any experience with it: https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html > Setting CMake mininum version to 3.20 and remove all the extra cmake...