Results 76 issues of Micah Lee

Right now when OnionShare starts a web service, it uses `app.run` to start it directly in flask. I think instead we should launch an `nginx` subprocess and use that along...

enhancement

![Screenshot from 2020-08-25 16-42-39](https://user-images.githubusercontent.com/156128/91238515-0e067600-e6f2-11ea-85e5-2b80d78d13b0.png)

bug
chat mode

![onionbrowser](https://user-images.githubusercontent.com/156128/117360170-4fe4e000-ae6d-11eb-86d3-f35f13b592ea.jpg) Source: https://twitter.com/Mittenzwei/status/1390393756684275716

documentation

In share mode, range requests work with `curl` and `wget`, but they fail with Tor Browser. To test: - Share some large-ish files - Load the URL in Tor Browser...

bug

The only way I could get OnionShare for macOS to successfully code-sign and pass Apple's notarization was to disable the sandbox. I'd like to spend more time re-enabling it before...

defense in depth
packaging
macos

I received some feedback about chat. Right now if you start a chat server and then wait for someone to join, and your screen locks, the websocket connection in Tor...

enhancement
chat mode
investigate

In #1016, @pabs3 pointed at that the documentation for `Flask.run` says: > Do not use run() in a production setting. It is not intended to meet security and performance requirements...

enhancement
defense in depth

As described in this comment https://github.com/micahflee/onionshare/pull/1096#pullrequestreview-442706222

chat mode

As @Baccount pointed out in #588, the images included in OnionShare appear to be low resolution, and so do the third party icons in the file list. I've decided to...

enhancement
ux

Re-add the instructions to `BUILD.md` to build PyInstaller from source. I just tested version 0.3.6 in Windows, and Windows Defender seemed to flag it and quarantine `gpgsync.exe` :(