Michael Maxwell

Results 32 comments of Michael Maxwell

I'm interested in helping with this item with some guidance 🙂

> > Hi, the previous PR seems to be closed due to inactivity. I am just wondering if I could take that over? > > If @mic-max is not planning...

@xyq175com The idea is to add a `case Guid` to the switch statement in Serialize linked in the issue. Currently a `Guid` object will fall into the `default` case and...

To add to @cijothomas comment The recommendation will be to use `OpenTelemetry.Instrumentation.Runtime` for any metrics it exposes instead of using `OpenTelemetry.Instrumentation.EventCounters`. The implementation of `Runtime` will provide more up-to-date values...

Are these the only 3 workflows to do this for?

I am working on making this instrumentation more stable. I will be - Add / enable testing - Cleaning up implementation - Looking into different possible bad scenarios, like enabling...

In OpenTelemetry we started a fork and have some work done to remove these duplicate `.proto` files as part of the following PRs: - https://github.com/open-telemetry/opentelemetry-demo-webstore/pull/118 - https://github.com/open-telemetry/opentelemetry-demo-webstore/pull/117 - https://github.com/open-telemetry/opentelemetry-demo-webstore/pull/116 -...

> This is something I've been meaning to address for a while but I haven't had the chance. I think the right way to do this is to entirely remove...

Definitely looks like a bug. I reproduced it with the CLI tool and it works for non-symmetric: ``` > jsondiff old.json new.json -i 2 { "network": { "domain": "new.domain" }...

Not currently, `json.dumps` is also how the `cli.py` does it