opentelemetry-dotnet-contrib icon indicating copy to clipboard operation
opentelemetry-dotnet-contrib copied to clipboard

EventCounter -> Metric API instrumentation

Open cijothomas opened this issue 4 years ago • 6 comments

An EventCounter listener which can get metrics emitted using EventCounter, and in-turn invoke the new Metric API. https://docs.microsoft.com/dotnet/core/diagnostics/event-counters

cijothomas avatar Oct 26 '21 22:10 cijothomas

@hananiel Assigning this to you since you mentioned interest in contributing this!

cijothomas avatar Oct 26 '21 23:10 cijothomas

Is the current plan to have this in the GA version or only coming later (which is fine)?

tomkerkhove avatar Jan 11 '22 06:01 tomkerkhove

This is not part of the API/SDK. This will likely be hosted in the -contrib repo, but no timelines yet. (One good thing is, we are not likely blocked by semantic conventions for the stable release of this, once code is ready)

cijothomas avatar Jan 11 '22 16:01 cijothomas

Sounds good, thanks for sharing!

tomkerkhove avatar Jan 11 '22 21:01 tomkerkhove

Looking forward!

twenzel avatar Jan 14 '22 08:01 twenzel

I am working on making this instrumentation more stable. I will be

  • Add / enable testing
  • Cleaning up implementation
  • Looking into different possible bad scenarios, like enabling the extension twice on the same provider
  • Filtering out metrics covered by other instrumentation (Runtime, Process)
    • Ensure it works in conjunction with other instrumentation so none of the events will be lost
  • Checking for memory leaks and minimize memory footprint as it will be enabled for the full lifetime of most applications that use it
    • Don't allocate memory after startup

mic-max avatar Aug 31 '22 22:08 mic-max