Michal Bohuslávek
Michal Bohuslávek
Hi, sorry for the delay. > To achieve this we must be able to use dupl as a library […] I think that's a great idea and I'm open to...
To elaborate further, this is the API implemented in your fork (if I understood correctly): ```go package api type Issue struct { From, To clones.Clone } func Run(files []string, threshold...
First let's discuss the package interface. Originally dupl was design to find clone _groups_, not necessarily pairs. Would that be a problem? I was thinking about names as well and...
First of all, sorry for my late response. > I think that we can swap > > ```go > type Group struct { > Clones []Clone > } > ```...
Thank you! But I agree with @shurcooL. It's not a good idea. What about a tool that would filter dupl's output, or its input. I understand the convenience of this,...
I have thought about it too, but I think this solution is not sufficient as sometimes it is only part of a file not to be included for clone-searching. And...
Yes, I know. Originally it wasn't supposed to be used in CI systems. This is an open issue because I don't know how to solve it. Does anyone have an...
Yes, totally agree. The purpose of dupl is slightly different from other tools that are usually run in CI systems.
Leaving this open though as I'm not entirely against the idea provided a reasonable solution is found. I understand some people might feel the urge to use it in CI...
I've come up with an ugly hack (that I personally don't intend to use) for this issue. Instead of using comments to control _dupl_'s behaviour, one can use dummy statements...