Maximilian Hils

Results 341 comments of Maximilian Hils

Thanks for the super fast reply, @basil00! I can reproduce the issue with WinDivert 1.1 and Windows 10. What system are you on, @ffalcinelli?

This is a Windows 10 issue, unrelated of Python. I cannot delete `WinDivert64.sys` as long as WinDivert 1.1.8 is running. "access denied" -> `sc stop` -> "success"

Thank you! The RX battery alert is just awesome. :smiley: :cake: :tada:

Yes, that's a good point. Killing currently only works from the event hook, we should probably rig it up to work more generally.

Thank you two for the feedback! This is really valuable. I think fundamentally there are two ways forward: 1. We can make command invocation more ergonomic and straightforward to use,...

The relevant code is here: https://github.com/mitmproxy/mitmproxy/blob/6494e97e781a03bc4df99fdde5ab8d6f3c5e7e9c/mitmproxy/tools/web/webaddons.py#L30 Seems like the Linux install does not ship with xdg-open or something like that?

This sounds like a bug in Python's webbrowser module to me when there's no `x-www-browser`, `gnome-open`, or `xdg-open` binary on the system and we fall back to Chrome. See the...

> Why even have the array when The default list includes stuff like `lynx`, which makes for a usability nightmare on server OSes. `x-www-browser` should probably not have the `%s`....

Yes - https://github.com/awestlake87/pyo3-asyncio/pull/39 might serve as some inspiration on what it might be.

I think I figured out how we get `InvalidStateError`s: 1. When our Rust future completes, pyo3-asyncio checks if the Python future has already been cancelled and calls `set_result` if that's...