Maximilian Hils

Results 341 comments of Maximilian Hils

Awesome, this looks like a great start! I'm really looking forward towards this. > Perhaps a future improvement would be to display it until the user presses a key? Or...

Ok, I think we have a great first proof-of-concept here, but we first need to figure out what we want the whole thing to look like eventually. Let's continue over...

Thanks for the excellent report! 🍰 So there's obviously something holding references to these flows, we just need to figure out what it is! 😄 What happened to the Flow...

Looking at your log again it looks like you're using the default SIGUSR1 handler and not the one I posted over at https://github.com/mitmproxy/mitmproxy/issues/4456#issuecomment-780710897. Running `mitmdump -s addon-from-comment.py` and then sending...

Not sure what's causing the TypeError, but let's just wrap the if clause with a big `try: if ... except TypeError: pass` clause. I guess you have some objects in...

There are 86471 flow objects if you look at the memory section, we just decide to print just one. 😅 Which.. in this case looks like one that is still...

Oh, that is interesting. Let's first focus on why flows are disappearing now: Are you using HTTP keepalive for all requests, i.e. is there a bunch of persistent connections?

Sorry, missed your reply in my inbox! :) HTTP/1.1 and HTTP/2 default to keepalive. Could you test if adding a `Connection: close` header changes anything? The following addon should do...

Thanks @wwcwang! This is really useful feedback, we now can think about how we clear out old streams so that this workaround is not necessary. 😃

Excellent. I think I have everything we need, I just need some time to properly tackle it. 😅