Michael Heimpold

Results 45 comments of Michael Heimpold

Hi Daniel, your are right, me too, I'm wondering whether this is the correct approach for a library. When I coded this PR, my main intension was to indicate the/my...

I prefer to call this 'quirks' instead of compliance, see my proposal here: https://github.com/mhei/libmodbus/commits/quirks

Even 6 years after my PR, I still like the idea of naming it "quirk" - stolen from Linux kernel where similar things exists for e.g. USB devices :innocent: >...

I've strong doubts, that you can fix such hardware issues with non-bare-metal-OS. Software workarounds like here in libmodbus or even in kernel space, are always operating on a best-effort base....

@jfsimon1981: I think you got confused by the Modbus timeouts... The RTS time handling calculations above tries to determine how long libmodbus must ensure that RTS is asserted to turn...

I would appreciate if you would restructure this PR: divide it in smaller changesets, each with a meaningful commit message for itself. This makes it easier to review. I would...

Indeed, this would be a cool feature. And you are right, the implementation is ... straightforward :smile: I'll try to test it next weekend, however, I cannot promise. I wonder,...

I've tested this only in a Linux environment and it seems to do the desired job so far. Windows code branch is untested - feedback welcome. Did anybody faced this...

@karlp: Thanks for your review time. I'd wait a few more days for other comments and then update this PR.

If this is a common public product, i.e. a USB RS-485 dongle and not a self-made hardware, then you could expect that this function is preconfigured accordingly. Usually, you don't...