Mikko Harju

Results 7 comments of Mikko Harju

Hmm, that seems odd – maybe we need an explicit include for `parquet/types.h` ..?

> It's possible that if you were only building on OS X you didn't hit this issue - maybe your build was using your shared libraries. The Linux build currently...

> This appears to be related to the long long changes - long term, we can do some platform specific ifdef, I guess. Although perhaps there's a third, more portable...

I added `long_t` typedef'd to `int64_t`, is that an overkill?

There is a bug in the build system that drops the architecture env variable that is supposed to go there from the builds – basically you can just grep all...

> @mharju Most of the files compile, but near the end I see this: > > ``` > Consolidate compiler generated dependencies of target mbgl-test-runner > [ 81%] Building CXX...

Bumped to the same issue. The `target: nodejs` was added in the commit saying it fixes `:closure-defines` and `:preloads`. To what extent do we need the `target: nodejs` to accomplish...