Mark Hammond

Results 678 comments of Mark Hammond

Feel free to reopen this if you'd like to pursue it!

> it would be nice to have a way to define impl fmt::Display for enums and records Yep, is related and that's the intent!

The defaults are needed by the bindings and currently need to conform to https://github.com/mozilla/uniffi-rs/blob/b46ab54ce0513dd4a9292e097e17e7ca28827795/uniffi_meta/src/lib.rs#L258. tbh though, I think we should consider deprecating these types in favour of [custom types](https://mozilla.github.io/uniffi-rs/next/types/custom_types.html) -...

Wouldn't we be better off just creating great docs from the procmacros?

For input to other tools, wouldn't a format that's machine readable be better? Otherwise these tools would need to take a dependency on our weedle2 fork and duplicate much of...

> #2081 highlights two issues: As you will see in that issue, I don't fully agree with the characterizations there. > The parser problem can be addressed via a fresh...

> Nord's [c++](https://github.com/NordSecurity/uniffi-bindgen-cpp?tab=readme-ov-file#generating-using-a-library-file), [C#](https://github.com/NordSecurity/uniffi-bindgen-cs?tab=readme-ov-file#how-to-generate-bindings), and [go](https://github.com/NordSecurity/uniffi-bindgen-go?tab=readme-ov-file#how-to-generate-bindings) binding generators all consume UDL. I believe they consume it indirectly via how I described it above (ie, they depend on `uniffi_bindgen`, not `weedle2`....

I'm afraid those docs are slightly misleading - creating bindings directly from the UDL only works in simple single-crate scenarios, but even in those scenarios, the fact the bindings don't...

A work-around for this landed: https://github.com/mozilla/uniffi-rs/blob/117d562de587db7ff04ebf03449481712fdb9132/fixtures/ext-types/proc-macro-lib/tests/bindings/test_imported_types.swift#L33-L36 We should work out to how re-enable that test for Swift 6. STR: * Execute `UNIFFI_TEST_SWIFT_VERSION=6 cargo test -p uniffi-fixture-ext-types-proc-macro` * Note the message...

I think the problem is toml - ie, https://searchfox.org/mozilla-central/rev/f63ca2952da98e0817bdae0ddf1314281a497106/Cargo.lock#5755-5762 - bumping that version here would probably mean m-c ends up with 2 versions of that crate which we try hard...