Mark Hammond comments

Results 678 comments of


                                            Mark Hammond

Avoid Option<DeviceType> in all structs

I update this in the following way: * Moved DeviceType to a new device_type.rs and added many comments about the semantics for serializing etc. * Deserialize "phone" as `DeviceType::Mobile` given...

[Bug] Metadata DB removes items from Places DB via referrer_place_id

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1866511 Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).

Add a function that would delete page visits from timestamp to timestamp

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1866348 Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).

Error during PlacesHistoryStorage$deleteEverything: Query returned no rows

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1866352 Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).

Better error telemetry

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1866357 Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).

Delete corrupted places databases, to allow the app to recover

We now delete files found to be corrupt at open time and we have #4639 to track deleting them found to be corrupt while operating on them so there's no...

Remove duplicate DeviceType enum from .udl files

Replaced by #5316

UrlParseFailed errors in noteHistoryMetadataObservation()

#5304 has made this redundant.

Analyze logic around `connUseAfterApiClosed` error

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1866512 Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).

Sync manager panic: index out of bounds

We haven't seen this recently, sync manager has since moved to uniffi and parking_lot, so I think we can close it.