Marc Guillemot

Results 17 comments of Marc Guillemot

@jdomag PR id is available as `env.CHANGE_ID`. Some other variables are availaible as well: https://javadoc.jenkins.io/plugin/pipeline-model-definition/org/jenkinsci/plugins/pipeline/modeldefinition/when/utils/EnvironmentNames.html Jenkins `httpRequest` step can be used to perform the request like: ``` httpRequest url: url,...

Hi maintainers, sorry to ask again but could one of you merge this PR or tell what should be changed? Thanks.

@car-roll, @bitwiseman could you have a look at this PR and merge it or provide feedback if it should be improved/changed?Thanks.

> What would help would to have some tests though 😅 @lifeofguenter can you point me on some existing tests that could help to get started here?

@lifeofguenter I really appreciate your activity for this plugin since a few days but it's quite depressing if you say that you don't feel qualified to review this PR. It...

@lifeofguenter I'm more than happy if you plan to look at this PR soon. Your previous comment has wrongly given me a false impression. Sorry for that.

AFAIK no built-in functionality for that. We use the httpRequest Plugin for that: ``` void postPRComment(String bitbucketProject, String repository, String prId, String message) { String url = "https://##bit-bucket-host##/rest/api/1.0/projects/${bitbucketProject}/repos/${repository}/pull-requests/${prId}/comments" httpRequest url:...

@jaikiran Is this PR ok for you? I'm waiting for this to be merged (or rejected) to submit a new PR with some common changes.

Hi @jaikiran, I understand the problems with the usage of `displayName`. What do you think of these first ideas to solve this issue without the problems you mention: - use...

@don-vip using display names can't be made the default because it would probably break existing usage. This means that an opt-in possibility needs to be created. I don't know what...