Mira Grudzinska

Results 98 comments of Mira Grudzinska

@capnm I've updated the pr, but it's still under rev

> @mgrudzinska I haven't had a chance to read through the code yet, had only a quick look at the SVG specs and Godot results with the last pr. The...

@capnm I didn't take a look in a godot code. the problem with incorrect size should be solved in the last commit. these are two separate cases: - svgs with...

I'm quite sure, that for the t3.svg (```viewBox="0 0 200 0"```) for the latest version of the corresponding pr (after changes pushed yesterday) you should get ```ERR_INVALID_DATA``` from the ```picture->load```...

omg it's a huge diff :D but I don't see what did you change in godot in image_loader_svg.cpp. could you share?

I'll be available in a few hours and i run it myself

1. so, the viewbox error is now solved in [#1318](https://github.com/thorvg/thorvg/pull/1318) 2. all svgs with the width or height value set to zero - in my opinion you have to handle...

@capnm good catch! I noticed this but I wanted to solve this after we agree with https://github.com/thorvg/thorvg/pull/1318 > After https://github.com/godotengine/godot/pull/75034 the svg import is now error free for all images...

great, so I'll take care now of this one extra pixel

why without `````` ? I'll take a look on each one of them later, but it seams that not all of them are really broken: KOSZ_8786 from tvg: ![d](https://user-images.githubusercontent.com/67589014/232527804-469c2211-9769-4fa7-a12b-dd2f702b9155.png)