Marc Redemske

icon location Berlin

Results 20 comments of Marc Redemske

firefox times out in Github Actions

@devversion sorry for my late reply, I got sidetracked from this issue. Thanks a lot for your further investrigations > The best solution seems to be to run the tests...

firefox times out in Github Actions

Adding `no-sandbox` to the `tags` of `web_test_suite` did it for me :star_struck: @devversion thanks for your support and explanation :pray:

Properly declare and import type definitions

@drewjbartlett, @yihou I would start fixing these errors

Properly declare and import type definitions

https://github.com/mgred/rapid.js/tree/rapid.js-41

Properly declare and import type definitions

I refactored so far to get rid of the `typings` directory.

Properly declare and import type definitions

@drewjbartlett I'm on a trip currently and will have look this evening.

Properly declare and import type definitions

@drewjbartlett I switched to my branch `rapidjs-41` where I made some refactorings. The test passes more or less but the promise seems not be handled correctly. ![test](https://user-images.githubusercontent.com/2325260/40271205-4c905520-5b9a-11e8-8c09-32ed133665a8.png) I still don't...

Properly declare and import type definitions

@drewjbartlett I still try to figure out why the tests are not running on the main refactoring branch, I updated the `tsconfig.json` to be like the one on my branch...

Properly declare and import type definitions

#45

Expose axios interceptor api

`axios` unfortunately does not export `InterceptorManager`, so we cannot instantiate one for every type in the `defaults.js`