Michał Górny

Results 218 comments of Michał Górny

Eclasses are cheap. Write multiple eclasses if it makes sense. Trying to make an all-in-one eclass is only going to cause confusion, mistakes and in the end, someone will waste...

Perhaps the answer is not to try to use a one-size-fits-all eclass and actually write ebuilds.

I'm sorry but I'm still going to give it the red flag, with a QA hat on. It is too early to add an eclass like this. ROCm should start...

For handling targets, sure. However, conflating that with additional logic for building very specific package is not clean at all.

Also, have you compared memory usage? Since you're doing unlimited cache without expiration, I suspect a lot of atoms may end up being cached after major depgraph processing, and they...

BTW congratulations, you've managed to DoS pull request assignment script by listing wrong bug ID in the second commit! So much for free Sunday…

> BTW congratulations, you've managed to DoS pull request assignment script by listing wrong bug ID in the second commit! > > So much for free Sunday… (please don't fix...

Could you please send this patch upstream to reviews.llvm.org? I can try to help you find reviewers if you need me to. I can backport it to Gentoo once upstream...