Michał Gołębiowski-Owczarek

Please switch from `.bind()`/`.unbind()` to `.on()`/`.off()`. The former are deprecated as of jQuery 3.0 and we plan to deprecate them in Angular's jqLite in 1.6 as well. `.on()`/`.off()` has been...

See: https://codepen.io/mgol/pen/GjKqka The main cause of the bug is the line at https://github.com/angular-ui/ui-mask/blob/1.8.7/src/mask.js#L341: ``` js if (angular.isDefined(placeholder) && placeholder[i]) { ``` `angular.isDefined(null)` is true and Angular Material makes `placeholder` be...

Avoid counting scroll twice in offset

2

> While we're here making changes, we could also account for scrolling. > ```diff > - // Incorporate borders into its offset, since they are outside its content origin >...

returnValue should be set to a truthy value

1

The Chrome fallback at https://github.com/jacobbuck/react-beforeunload/blob/a271f7a01f9fd5309d9f859f5e805c9c3c8ba28c/src/useBeforeunload.js#L34 sets `event.returnValue` to an empty string. However, the confirmation dialog should only be shown when the value is truthy despite Chrome not following this part...

See https://jquery.com/upgrade-guide/3.0/#callback-exit, in particular the paragraph: > Note that jQuery logs a message to the console when it is inside a Deferred and a JavaScript exception occurs. These messages take...

The "common widget" tests, checking if a widget doesn't overwrite some core widget APIs wasn't running as it was incorrectly checking for `$.uiBackCompat === false` instead of `$.uiBackCompat !== true`...

### Description ### #5523 used a template literal in the test, with GitHub Actions all green. ESLint should catch it and it should not allow ES2015+ syntax in test files....

Tests: Run tests in Edge in IE mode in GitHub Actions

1

### Summary ### While Edge in IE mode is not guaranteed to match IE 11 in every aspect, in practice it generally does. Testing in this mode in GitHub Actions...

Prepare a 4.0 upgrade guide

3

An incomplete list of items to cover: ### Undocumented but still mention The undocumented `jQuery.fn.init` API no longer accepts the third `root` parameter: https://github.com/jquery/jquery/pull/5096

Should we keep `test/*.html` files?

1

Our `test` folder has a bunch of HTML files with manual tests. Let's discuss whether these files actually serve any purpose. We're not using them at the moment as can...