Michał Gołębiowski-Owczarek comments

Results 837 comments of


                                            Michał Gołębiowski-Owczarek

Upgrade to ESLint 9

@miyasudokoro No worries. Right now, we're busy trying to get `4.0.0-rc.1` out the door anyway, it'll take some time.

Update ESLint on main to >=9.20.1

Thanks for the info. I don't think https://github.com/import-js/eslint-plugin-import/issues/2678 blocks us but https://github.com/import-js/eslint-plugin-import/issues/3079 definitely does. Let's track this one.

Update ESLint on main to >=9.20.1

Actually, scratch that, both are relevant. BTW, I was following the comment above the commented our rule; it seems it's incorrect then.

Build: Test on iOS 18, no longer test on iOS 15

Converting to a draft for now: iOS 18 is unstable on BrowserStack now; let’s leave it just on Migrate until the issue is fixed. I reported it to BrowserStack.

Warn against legacy selector pseudos, backfill the API

PR: #546

Docs: Create Bug and Feature Request Forms

Thanks for the PR. Please sign our CLA, we cannot merge contributed code otherwise.

Document `toggleClass(boolean)` & `toggleClass(undefined)` are removed in 4.0

PR: #1256

Fix: focus event fires on disabled inputs

I’m sorry, I mixed up PRs, let me reopen this one. I don’t think the changes will be that small, though; we also need to handle at least `blur`, get...

`focus` event fires on disabled inputs

Thanks for the report. I migrated it to a JS Bin (please try to submit a test case via a platform like that in the future, that makes it a...

`focus` event fires on disabled inputs

It's worth pointing out that the same behavior for `click` - triggering `click` on disabled inputs - fires the handler even in jQuery 2.2.4 while the native `.click()` call does...