Michał Gołębiowski-Owczarek comments

Results 875 comments of


                                            Michał Gołębiowski-Owczarek

Autocomplete widget should use bound item.label property as a fallback for empty aria-label.

Thanks for the report. Does the issue you describe exist when jQuery UI 1.12.1 is used or only with jQuery UI 1.13.0 or newer?

Autocomplete widget should use bound item.label property as a fallback for empty aria-label.

Thanks for the info. Can you provide a test case on [JS Bin](https://jsbin.com/qawicop/edit?html,css,js,output)? Thanks!

Add a new `wheel` event, deprecate the `mousewheel` one

We settled on option 1.

Script tags now used for most async requests in 4.0

@vlakoff that's a good point. Would you like to submit a PR with a proposed wording? Please tag me on it if you do. As for a workaround, I think...

Consider removing the `.css()` behavior of detecting vendor-prefixed versions of props

Interesting trivia: in the jQuery 1.8.0 release blog post, the property used to show the auto-prefixing feature was exactly `user-select`: https://blog.jquery.com/2012/08/09/jquery-1-8-released/.

Consider removing the `.css()` behavior of detecting vendor-prefixed versions of props

I did a quick test with a few scripts: First, I collected all properties in camelCase style for the current browser. ```js 'use strict'; var prop; var style = document.createElement('div').style;...

Consider removing the `.css()` behavior of detecting vendor-prefixed versions of props

TBH, looking at the above lists, if it weren't for `user-select`, I'd be for removing the prefixing mechanism even for `4.0.0`.

Consider removing the `.css()` behavior of detecting vendor-prefixed versions of props

Can I Use for `user-select`: https://caniuse.com/mdn-css_properties_user-select

Make the uiDialogTitle configurable

Thanks for the report. I'd rather avoid adding more options as then we need to maintain them indefinitely. Since h1 seems to be OK per your description, I'd try that....

Make the uiDialogTitle configurable

I've just realized we cannot do this for all dialogs as non-modal ones don't get the `aria-modal` attribute set so out-of-dialog headings are still available. This would have to be...