Michał Gołębiowski-Owczarek
Michał Gołębiowski-Owczarek
I can submit a PR with optional chaining for `parent` but I'm not sure how to test it.
I think the main bug is in Danger JS. `override-require` first calls `isOverride` with the parameters it received, the incorrect assumption was just that `isOverride` will receive a truthy `parent`....
`cjsLoader (node:internal/modules/esm/translators:356:17)` is also good to look at - the following line: https://github.com/nodejs/node/blob/925a464cb8bab007dfc0ac5856b76134cdfda1cc/lib/internal/modules/esm/translators.js#L359 is just: ```js CJSModule._load(filename); ```` Note the lack of the `parent` parameter, leaving it undefined. `CJSModule` here...
I guess my question here is - for the kind of module requests that are missing a parent, is it OK to assume `shouldUseGitHubOverride` may return `false`? If not then...
It took me a while as I was on paternity leave but here it is, @fbartho: #1430
`index.mjs` is missing its type definitions. The file is declared in the `exports` part of `package.json`: https://github.com/andywer/threads.js/blob/0d1a882f09273cb8482902ae2601fe4ffed6fbab/package.json#L24-L41 so any tool that started evaluating `exports` instead of `main` or `module`: https://github.com/andywer/threads.js/blob/0d1a882f09273cb8482902ae2601fe4ffed6fbab/package.json#L6-L7...
`filter` is a nice workaround but it also catches test titles from other modules. I know about the `moduleId` way but this is not that useful when you want to...
Grunt tasks cannot return anything, they just execute code (which may result in creating/deleting/modifying some files) and they may succeed or error. There is no consumable output, the task may...
That seems like useful feature request, thanks! I think, though, that current output of the check-dependencies package is sub-optimal for that use case; the messages are just text & nothing...
I won't get to it within the next week or two because of conferences so if no one submits PRs I'll get to it afterwards.