Michał Gołębiowski-Owczarek

Results 875 comments of Michał Gołębiowski-Owczarek

Thanks for the report. In general, libraries modifying native methods should be included first as otherwise there may be a mismatch between whatever jQuery manages to cache internally before the...

Older versions of Sizzle didn't rely on `:scope` so much; newer do for performance reasons. So yes, something changed on the jQuery side but that doesn't change what I wrote...

BTW, Sizzle actually does have a support check for `:scope` support; this is most likely why moving the Shady polyfill before jQuery works - at the point where jQuery does...

I see there already is a similar issue so I just posted there: https://github.com/webcomponents/polyfills/issues/480

@blackjackyau We have a few questions. What does it exactly mean that the library is built with the assumption of the ShadyDOM polyfill? What does the polyfill have that the...

Why do you need a workaround currently, though? The issue I described will only manifest itself in jQuery 4.0. The one you reported here originally is caused by the polyfill...

It'd be good to figure out what's causing the issue considering the hackiness of the current solution. If you can host the broken version somewhere, I could have a look....

@codefactor Thanks for the report. There's actually no difference in converter code; converters also run in jQuery 2.x. This is a result of one of fundamental assumptions of `jQuery.ajax` -...

We'll re-evaluate this for `5.0.0`. It has a potential of breaking existing code so it needs to land in a major version update and we're trying to not add more...

cc @gibson042 @jaubourg: is this intended?