Martin Gencur

/test upgrade-tests

Hmm, the eventing-webhook doesn't start after downgrade, I see these events: ``` knative-eventing 11m Warning Unhealthy pod/eventing-webhook-5c974857b-jjkjl Readiness probe failed: Get "https://10.68.0.8:8443/": remote error: tls: unrecognized name knative-eventing 6m56s Normal...

/test upgrade-tests

The failures are caused by ContainerSource being deployed which brings SinkBinding and the test scripts try to scale down to 0 and back to 3, see https://github.com/knative/eventing/issues/8161

Added a workaround for https://github.com/knative/eventing/issues/8161 which makes the tests pass.

> This seems like a huge upgrade on the existing upgrade tests. Maybe once we have this in eventing and are happy with the API we can also look into...

> We could make it more configurable, for example [these EnvOpts](https://github.com/knative/eventing/pull/8158/files#diff-fcd6c2c27a895f687ac3a94c7f06c28ef4fb4bb657a301c9d3135d6726f22830R71-R74) could be held as a field in DurableFeature I did that and pushed another commit here.

/retest-required

The [test log](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/8158/upgrade-tests_eventing_main/1824044297075298304#1:build-log.txt%3A4255) shows that downgrade fails with: ``` executor.go:189: Aug 15 11:44:52.727 install_latest_release [ERR] Error from server (InternalError): Internal error occurred: failed calling webhook "sinkbindings.webhook.sources.knative.dev": failed to call webhook:...

My experiments show that adding the label `bindings.knative.dev/exclude=true` to the knative-eventing namespace fixes the issues. But this is rather a workaround because we [already put this label on individual objects](https://github.com/knative/eventing/commit/3af0fac92d713cf3cc0c869398ea01b031681340)....