Martin Gencur
Martin Gencur
The test fails with: ``` system_internal_tls_test.go:234: Deleting trust-bundle ConfigMap stream.go:305: D 11:08:49.430 autoscaler-7d8fbf5b9-m86j7 [metrics/stats_scraper.go:252] [serving-tests/tls-certificate-rotation-ebvlcsmm-00001] |OldPods| = 1, |YoungPods| = 0 spoof.go:110: Spoofing tls-certificate-rotation-ebvlcsmm.serving-tests.example.com -> 34.138.175.134 system_internal_tls_test.go:254: The endpoint http://tls-certificate-rotation-ebvlcsmm.serving-tests.example.com/...
The test passed when I added waiting for ca.crt in routing-serving-certs. Will try again during reviews.
@ReToCode this is ready for another review.
@ReToCode @dprotaso OK. I went ahead and fixed the shell check.
@ReToCode Hmm. The latest error looks genuine: ``` system_internal_tls_test.go:225: Deleting secret in system namespace spoof.go:110: Spoofing tls-certificate-rotation-jryhlssh.serving-tests.example.com -> 35.231.189.127 stream.go:305: D 08:40:20.489 autoscaler-56bfd47c76-4m7mn [statforwarder/processor.go:119] [serving-tests/tls-certificate-rotation-jryhlssh-00001] Forward stat of bucket autoscaler-bucket-07-of-10...
@ReToCode As you mentioned [here](https://github.com/knative/serving/pull/15217#discussion_r1607753785), we should not be deleting the old cert from the trust-bundle ConfigMap because the test is quick and the certificates might not be rotated yet....
/cherrypick release-1.20 /cherrypick release-1.19