Martin Geisler

Results 915 comments of Martin Geisler

Hi @gendx, I think you've played a lot with unsafe... can you review this? Thanks :smile:

To me, it avoids front loading: the imports currently have a lot of _details_ from the code below. They're complex, with funny dances in the form of `std::fs::{self, ..}` —...

Let's drop this, i have other cleanups for the same slides :smile:

For reference: https://github.com/KaiserY/trpl-zh-cn.

Hi @kiwiwarmnfuzzy, the script it here: https://github.com/google/comprehensive-rust/pull/291. I asked the other translators, and they tell me that they haven't seen the same off-by-one errors. Here is the output from a...

> Oh no worries I wasn't using your script. Great to hear that!

Hi there, just a small note: please rename the file to `zh-CN.po` so that the translation will eventually appear under `.../zh-CN/`. The `_` to `-` change should give us the...

From reading https://developers.google.com/search/docs/specialty/international/localized-versions, I'm thinking we should name the Simplified Chinese translation `zh-Hans` like @taotieren does in #436.

> Got it. I've been occupied by my COVID and ISCA rebuttal lately. Ugh, sorry to hear that! I had COVID myself last year and it was not fun at...

> I think called Chinese Simplified is better. Hi @xusiwei, I tried looking this up and from what I can understand, you're right: we should call the translation "Chinese (Simplified)"...