Martin Geisler

Results 878 comments of Martin Geisler

> So far, I'd also say that we already have a lot of material. At the same time, I agree with the reasoning that "comprehensive" course shouldn't leave out important...

Hi @Marvin182, thanks for the PR! > Add a little example that demonstrates that the compiler checks lifetimes of references. The example is not bad, but I fear that it...

Let's close this PR for now — we can then open another PR for the thing about drop flags later.

This is of course a bit of an open ended issue :slightly_smiling_face: What I hope for is that someone will look at what `mdbook keeper` can do for us: -...

Thanks @mauvealerts! That's already a very valuable analysis! For example, I had not realized that you run the tests all the time... so we would definitely only enable it on...

Thanks for pushing this! > * Decide where the skeleton project should go (currently `mdbook-keeper-deps`) I think this should be the root of the repository, or perhaps the `src/` folder....

> I've also locked `mdbook-keeper` to the `markdown` output format, so it doesn't slow down `mdbook serve` Ah, that's a clever work-around :smile: However, it almost suggests that `mdbook-keeper` should...

Hey @CodeMaster7000, Thanks, you're right that the file should be named `LICENSE` — I see that https://github.com/google/new-project uses that name too. Can you update https://github.com/google/comprehensive-rust/blob/main/src/credits.md too?

> Since the head repository has been deleted, I can no longer go back and make changes to this PR. However, #272 has the requested changes so both PRs should...

I tested this today in a class and it worked well! The person at the back of the room could read the text fine when I zoomed the window to...