Michael Frey

[CVE-2018-6480] - type confusion in ccnl_fwd_handleInterest

5

Hi, the following code in ``ccnl_fwd_handleInterest`` assumes that the union member ``s`` is of type ``ccnl_pktdetail_ndntlv_s``. However, if the type is in fact of type ``struct ccnl_pktdetail_ccntlv_s`` or ``struct ccnl_pktdetail_iottlv_s``,...

Parameter opts is garbage after exiting function ccnl_mkInterest

2

#### Description In case a ``NULL`` pointer is passed for parameter ``opts`` of type ``ccnl_interest_opts_u`` in function ``ccnl_mkInterest`` a default value is assigned. Unfortunately, the default value is local and...

#### Description The value of ``len``in file ``ccnl-pkt-ccnb.c`` in [line 217](https://github.com/cn-uofbasel/ccn-lite/blob/master/src/ccnl-pkt/src/ccnl-pkt-ccnb.c#L217) is a garbage value since the variable is never initialized and hence the performed check will fail. #### Steps...

#### Description I've started to add unit tests for ``ccnl-core`` and noticed that our current ``CMakeLists.txt`` in ``test`` does not support various defines we use over the project. As a...

We have only have a vague understanding of our code coverage. If we would add gcov (and lcov for reporting) to our test builds, we would get insights on the...

deprecated API calls in unit tests

5

#### Description If you build the unit tests with a recent version of cmocka, the compiler will produce warnings about deprecated calls to ``_run_tests``. #### Steps to reproduce the issue...

re-design struct ccnl_relay_s

4

I propose to re-design the ``struct ccnl_relay_s`` data structure gradually. The struct is used as a global variable which is passed to functions throughout CCN-lites codebase which already has caused...

release management

2

Is there a rationale behind the version numbers? As far as I understood, we are on ``2.0.0`` since a lot of code has been re-organized, rewritten, etc. I'm wondering what...

clean up logging statements

1

We should improve the quality of the code of the ccn-lite logging mechanism. While browsing the code, I often read code like the following ```C 46 char s[CCNL_MAX_PREFIX_SIZE]; 47 (void)...

address TODO statements proactively

1

We should address the TODO statements. Check if the statements are valid (and/or outdated) and try to fix them, e.g. ```C 40 // TODO: remove unused ccnl parameter 41 struct...