ccn-lite icon indicating copy to clipboard operation
ccn-lite copied to clipboard

address TODO statements proactively

Open mfrey opened this issue 6 years ago • 1 comments

We should address the TODO statements. Check if the statements are valid (and/or outdated) and try to fix them, e.g.

 40 // TODO: remove unused ccnl parameter
 41 struct ccnl_content_s*
 42 ccnl_content_new(struct ccnl_pkt_s **pkt)
 43 {

There seems to be no ccnl parameter anymore. If a TODO item is an remark, there should be a comment in the code about it. I propose this should be done before the next release! Any thoughts?

mfrey avatar May 16 '18 08:05 mfrey

Also, git grep to the rescue, i.e.

$ git grep TODO
CMakeLists.txt:    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wextra -Wall -Werror -std=c99 -g -pedantic") #TODO: add -fsanitize=address
build-test-helper.sh:    # TODO: fix $NO_CORES!
ccnl-core/include/ccnl-sockunion.h:/* TODO: remove when af_ieee802154.h is in linux mainline */
ccnl-core/src/ccnl-array.c:            // TODO: warning
ccnl-core/src/ccnl-array.c:            // TODO: warning
ccnl-core/src/ccnl-array.c:            // TODO: warning
ccnl-core/src/ccnl-content.c:// TODO: remove unused ccnl parameter
ccnl-core/src/ccnl-interest.c:    while (pend) {  // TODO: is this really the most elegant solution?
ccnl-core/src/ccnl-mgmt.c://  TODO: Add ccnl_mgmt_prefixunreg(ccnl, orig, prefix, from)
ccnl-core/src/ccnl-prefix.c:// TODO: This function should probably be moved to another file to indicate that it should only be used by application level programs
ccnl-core/src/ccnl-prefix.c:            // TODO: this only works for chunknums smaller than 255
ccnl-core/src/ccnl-prefix.c:            // TODO: this only works for chunknums smaller than 255
ccnl-core/src/ccnl-prefix.c:// TODO: move to a util file?
ccnl-core/src/ccnl-relay.c: #ifdef USE_TIMEOUT_KEEPALIVE // TODO: shouldn't this be USE_NFN_REQUESTS?
ccnl-core/src/ccnl-relay.c:                                     /* TODO: show correct interface instead of always 0 */
ccnl-fwd/src/ccnl-fwd.c:        ccnl_mgmt(relay, (*pkt)->buf, (*pkt)->pfx, from); // use return value? // TODO uncomment
ccnl-nfn/src/ccnl-nfn-krivine.c:    // TODO: count opening/closing parentheses when hunting for ';' ?
ccnl-nfn/src/ccnl-nfn-krivine.c:        //TODO CHECK IF INT
ccnl-nfn/src/ccnl-nfn-krivine.c:        //TODO Check? //TODO remove interest here?
ccnl-nfn/src/ccnl-nfn-krivine.c:            mapping->key = ccnl_prefix_dup(name); //TODO COPY
ccnl-nfn/src/ccnl-nfn-krivine.c:    // TODO: count opening/closing parentheses when hunting for ';' ?
ccnl-nfn/src/ccnl-nfn-krivine.c:            // TODO: is the following needed? Above search should have
ccnl-nfn/src/ccnl-nfn-krivine.c:    char res[64000]; //TODO longer???
ccnl-nfn/src/ccnl-nfn-requests.c:    // TODO: verify arg, error handling
ccnl-nfn/src/ccnl-nfn-requests.c:    // TODO: add arg index as parameter
ccnl-nfn/src/ccnl-nfn-requests.c:void // TODO: is this still needed?
ccnl-nfn/src/ccnl-nfn-requests.c:void // TODO: is this still needed?
ccnl-nfn/src/ccnl-nfn-requests.c:// TODO: ccnl not needed.
ccnl-nfn/src/ccnl-nfn.c:    // TODO: this is not an elegant solution and should be improved on, because the clients cannot send a
ccnl-pkt/include/ccnl-pkt-ccntlv.h:#define CCNX_TLV_G_Pad                          0x007F // TODO: correcty type?
ccnl-pkt/include/ccnl-pkt-ccntlv.h:// #define CCNX_TLV_IntFrag                        0x0001 // TODO: correct type value?
ccnl-pkt/include/ccnl-pkt-ccntlv.h:// #define CCNX_TLV_ObjFrag                        0x0002 // TODO: correct type value?
ccnl-pkt/src/ccnl-pkt-ccntlv.c:    // TODO: check keyid
ccnl-pkt/src/ccnl-pkt-ccntlv.c:    // TODO: check freshness, kind-of-reply
ccnl-pkt/src/ccnl-pkt-ndntlv.c:                        // TODO: requires ccnl_ndntlv_includedNonNegInt which includes the length of the marker
ccnl-pkt/src/ccnl-pkt-ndntlv.c:                        // TODO: again, includedNonNeg not yet implemented
ccnl-riot/src/ccn-lite-riot.c:                            /* TODO: handle broadcast addresses which are not all 0xFF */
ccnl-riot/src/ccn-lite-riot.c:        /* TODO: receive from socket or interface */
ccnl-riot/src/ccn-lite-riot.c:            /* TODO: reduce timeout value */
ccnl-riot/src/ccn-lite-riot.c:/* TODO: move everything below here to ccn-lite-core-utils */
ccnl-riot/src/ccn-lite-riot.c:    /* TODO: support other suites */
ccnl-unix/src/ccnl-unix.c: * TODO: The variables are never updated within the context of
ccnl-utils/ccn-lite-fetch.c:        // TODO: asumes that chunk is at the end!
doc/Doxyfile.in:# The GENERATE_TODOLIST tag can be used to enable (YES) or disable (NO) the todo
doc/Doxyfile.in:GENERATE_TODOLIST      = YES
py/README.md:## TODOs

mfrey avatar May 16 '18 08:05 mfrey