Markus Podar

> However the `getJWTCustomClaims()` function is never called when a token is refreshed. Upfront: it works for me. Does your `User` model have the interface `\PHPOpenSourceSaver\JWTAuth\Contracts\JWTSubject` implemented, and not just...

Ah, didn't see this PR. Conflicts with https://github.com/PHP-Open-Source-Saver/jwt-auth/pull/233, we should make a decision which one to merge first. Of course I recommend mine :) Also because the v5+ upgrade is...

No objections, but I would like to see smaller iteration. For example, upgrading of one library but dropping multiple versions of Laravel support does not belong into a single change....

I made https://github.com/PHP-Open-Source-Saver/jwt-auth/pull/238 and concentrated only on the removal parts, because there are more opportunities of stuff to do. I suggest once my removal PR is merged, a separate one...

> legacy codebase I hate to "out myself", but I work on what I consider a more modern codebase and I find it _still very useful_ to have.

HOLY 🐮 I gave up on this… this makes me _so_ happy to see this back. Thank you @sebastianbergmann , this is really really appreciated (also 🙇🏼 to those who...

> I want to use phpunit test filtering capabilities to separate the huge PHPStan test-suite into groups which I can run in parallel in GitHub Actions. It's not the same...

I tested this on a private project and the performance improvements are incredible! I cannot directly compare Apples vs. apples (pun slightly intended), as my host is macOS and when...

My personal take (as I've expressed in https://github.com/rebing/graphql-laravel/pull/612#pullrequestreview-387360786 ): I don't think the approach using `SelectFields` is technically appropriate here. It relies on _upfront_ figuring out everything needed so that...

Maybe we should add a "caveat" section to the readme and note some known limitations? 🤔