jwt-auth icon indicating copy to clipboard operation
jwt-auth copied to clipboard

Published 20 hours ago • verified publisher icon PHP-Open-Source-Saver

Support lcobucci v5+ and drop support for anything below laravel 9

Open krenor opened this issue 1 year ago • 8 comments

Support lcobucci/jwt ^5.0 and drop support for versions below Laravel 9

Description

Checklist:

  • [x] I've added tests for my changes or tests are not applicable
  • [ ] I've changed documentations or changes are not required
  • [ ] I've added my changes to CHANGELOG.md

krenor avatar Feb 14 '24 11:02 krenor

@krenor can you solve the conflicts, please?

Messhias avatar Feb 21 '24 10:02 Messhias

Ah, didn't see this PR.

Conflicts with https://github.com/PHP-Open-Source-Saver/jwt-auth/pull/233, we should make a decision which one to merge first.

Of course I recommend mine :)

Also because the v5+ upgrade is disrupting, adding L11 support not.

mfn avatar Feb 21 '24 10:02 mfn

@mfn Sure, since yours also targets L11. Although I don't see a reason to support Laravel Versions that are EOL.

I'd like to get Lcobucci to v5. Shall I make a separate PR based on your branch?

krenor avatar Feb 21 '24 12:02 krenor

No objections, but I would like to see smaller iteration.

For example, upgrading of one library but dropping multiple versions of Laravel support does not belong into a single change.

(personally I'm also in favour dropping everything below L9 and PHP 8.1 ASAP)

mfn avatar Feb 21 '24 13:02 mfn

I made https://github.com/PHP-Open-Source-Saver/jwt-auth/pull/238 and concentrated only on the removal parts, because there are more opportunities of stuff to do.

I suggest once my removal PR is merged, a separate one with lcobucci v5+ should be made.

mfn avatar Mar 18 '24 13:03 mfn

@krenor can you check out this conflicts for us?

Messhias avatar Mar 19 '24 21:03 Messhias

@krenor are you able to check it for us?

Messhias avatar Apr 08 '24 11:04 Messhias

@krenor are you able to check it for us?

I will try to find time for it this week 👍

krenor avatar Apr 09 '24 08:04 krenor

@krenor are you able to check it for us?

I will try to find time for it this week 👍

Hi, how are you doing?

Can you manage some time this week to solve this? We would like to merge this feature.

Messhias avatar May 09 '24 09:05 Messhias

I am also interested in this PR after the 2.3.0 release. All other dependencies in my app support lcobucci/jwt:^5.0 except this one, so this change would allow me to update

kellerjmrtn avatar May 10 '24 16:05 kellerjmrtn

I am also interested in this PR after the 2.3.0 release. All other dependencies in my app support lcobucci/jwt:^5.0 except this one, so this change would allow me to update

Would you like to fix the conflicts and make this PR mergeable for us?

Messhias avatar May 10 '24 16:05 Messhias

PR created here #248

kellerjmrtn avatar May 10 '24 21:05 kellerjmrtn

Closing in favor of PR https://github.com/PHP-Open-Source-Saver/jwt-auth/pull/248

Messhias avatar May 14 '24 23:05 Messhias