Maxim Fateev

Results 94 comments of Maxim Fateev

It looks like distinguishing among the long poll and the short poll for getResult is non trivial. So we decided to postpone this change for now. The proposed workaround is...

It would be nice to keep all the spring integration is a separate package and ideally in a separate maven library. I'm not sure how to build multiple libraries with...

Proposal is to have ReplayActivityFromJSONFile given the file and the eventID of the ActivityTaskScheduled event.

You can define your own Register function that wraps activity in your own interceptor and calls activity.Register with your interceptor.

You could do something like: ``` func RegisterWithInterceptor(af interface{}) { afName := getFunctionName(af) wrappedAF := wrapWithInterceptor(af) activity.RegisterWithOptions(wrappedAF, &activity.RegisterOptions{Name:afName}) } ``` The problem is that the getFunctionName is not currently public....

Yes. You could use [reflect.MakeFunc](https://golang.org/pkg/reflect/#MakeFunc) to create the wrapper. It certainly looks like non trivial exercise at this point. We are going to think how to provide more generic solution...

Java supports [WorkflowInterceptor](https://github.com/uber/cadence-java-client/blob/7912a840aefdd3f1ebdb96f94d709f874b95bc44/src/main/java/com/uber/cadence/worker/WorkerOptions.java#L174). I think go should use the same approach. Both Java and Go have to add ActivityInterceptor as well.

The current interceptor is far from ideal, but should be Ok for your use case: https://github.com/uber/cadence-java-client/blob/d56612f05108efd4696310935d99def3a794f915/src/main/java/com/uber/cadence/worker/WorkerOptions.java#L174

I tried doing this. The problem is that that Go doesn't recognize method signature change: ``` ../client/client.go:403:27: cannot use "go.temporal.io/temporal/internal".NewClient(service, domain, options) (type "go.temporal.io/temporal/internal".Client) as type Client in return argument:...