Carlos Fuentes comments

Results 528 comments of


                                            Carlos Fuentes

Change assert.strictEqual to a safe early exit

~~Yeah, let's flush this and release it asap; I'll work on the proper fix after that and release a second patch~~ Let's narrow our focus to #818

"preprocessed" headers

Like the idea/approach for the immutable headers concept; one thing that grasped my attention was the each header being represented with a class. Do we need such fine grain representation?...

do not encode with encodeURIComponent if query with method GET passed.

Can you provide an [Minimum Reproducible Example](https://stackoverflow.com/help/minimal-reproducible-example) that outlines the behaviour that is leading to the failures?

maxRedirections option doesn't work anymore since v7

Yeah, the `maxRedirections` shouldn’t be available, maybe a left over; the redirections feature was moved into the `redirect` interceptor. Contributions are welcomed if the TS does not align or documentation...

maxRedirections option doesn't work anymore since v7

Yeah, there was no validation in place, #4311 has been opened to address that 👍

maxRedirections option doesn't work anymore since v7

This is the documentation for the `redirect` interceptor: https://undici.nodejs.org/#/docs/api/Dispatcher?id=redirect

Add a proxy server example for testing undici fetch.

This is an example of a server proxy with `proxy` ```js import * as http from 'node:http' import { once } from 'node:events' import { createProxy } from 'proxy' import...

Can you add an example to README as to how to broadcast a message to all worker threads using `BroadcastChannel` (Node v18+)?

Closed by #656

Cache cacheable response with an error status code

I'm aligned with the proposal, but have my concerns about going straight ahead into cashing non-2xx responses as it might be a breaking change for current usage. I'd advice the...

Default pipelining to maxConcurrentStreams with allowH2

I'm not sure this is a bug per-se, rather an improvement in the way we setup H2 (as `undici` was pointing to be only 1.1 compatible). Adding a new option...