Carlos Fuentes

Results 528 comments of Carlos Fuentes

>I think it would be a semver major change on undici and thus on node. So it would be Node 22. Curious, why do you suggest it should be a...

And `llhttp 9` is the only one containing this fix? If so, I see now the recommendation; I'm not sure what would be the implications for current usage, but maybe...

Thanks, @ShogunPanda that clarifies my doubts, then the approach SGTM 👍

@ShogunPanda beat me 💨 Same question. >Also asked the same here for reference: https://github.com/nodejs/undici/issues/3386#issuecomment-2238713810

My bare guess seems that it roots to the way you are cloning the request before the actual loop: ```js console.log(await request.clone().text()); // vs const cloned = request.clone() console.log(await request.text());...

FWIW, This can be achieved in the same way with the current interceptor setup. e.g. ```js return (dispatch: Dispatcher['dispatch']) => { return function intercept(requestOptions: Dispatcher.DispatchOptions, handler: Dispatcher.DispatchHandlers) { // if...

Yeah, AsyncGenerators cannot be re-used/consumed in parallel. Can you elaborate why bad? The interceptors API has been made for these kind of purposes

In pro of an improved lifecycle hooks API. I believe something like `onRequestSent` (that is triggered only after the full Request is sent) could be beneficial (I'll add `onRequestError` on...

Take a look at https://github.com/nodejs/undici/blob/0a069ab1f2d111b8e74f2d444d7f5678e302f39d/lib/client.js#L1639, there we manage everything related to `http2`