Charles Wagner
Charles Wagner
@phutchins can you review, merge, and bump the version with this change please? Currently `https://github.com/creationix/nvm.git` redirects to `https://github.com/nvm-sh/nvm.git` but it fails in the cookbook ``` [2021-11-02T19:10:06+00:00] FATAL: Chef::Exceptions::MultipleFailures: Multiple failures...
Current issue: https://github.com/fluent/fluent-bit/issues/9018 Other issue related to this PR fix https://github.com/fluent/fluent-bit/issues/5062
> It would probably be good to add some simple tests as well to prevent any future regressions? @patrick-stephens I wasn't able to get my local environment setup to correctly...
> The test runs but fails since the http service is responding with 400. @pwhelan Is it possible the test server is just rejecting the request based on the content...
> Note the change is failing to compile on the older compiler for CentOS 7 which is a hard block on merging. This [issue](https://github.com/fluent/fluent-bit/actions/runs/9746967853/job/26932543054?pr=9023#step:4:245) looks to be a [DNS issue](https://unix.stackexchange.com/questions/260547/cannot-find-a-valid-baseurl-for-repo-base-7-x86-64-on-yum-update-all).
> > > Note the change is failing to compile on the older compiler for CentOS 7 which is a hard block on merging. > > > > > >...
> Here is the updated patch: @pwhelan thank you. I applied your test patch https://github.com/fluent/fluent-bit/pull/9023/commits/daee63ed0f745f89f272d75241ed4278be68743f
> unit tests are failing, moving it to the next milestone @edsiper I believe I corrected the failing test https://github.com/fluent/fluent-bit/pull/9023/commits/48ebaad055fc2984f7d091af7e88feba4c1cfa82 https://github.com/fluent/fluent-bit/pull/9023/commits/ad1fd07c5c404c509b4ba31a1b316ed0cc8c0466 CC @pwhelan
@pwhelan can you please kick the unit test workflow https://github.com/fluent/fluent-bit/actions/runs/9858806052 ?
@pwhelan not being able to run the unit tests locally is definitely a problem on my end. Sorry for the churn.