Matt Stinson

> In ideal gases the enthalpies at in and outlet should be the same. Whether or not there is an issue here or not in the Modelica Fluid library, I...

> > > > @mestinso You pointed that out that we are left with `h_in + V_in^2/2 = h_out + V_out^2/2`, but I believe that Modelica.Fluid.Pipes.DynamicPipe neglects the kinetic term...

One lead I'm seeing regarding the kinetic energy term: ``` parameter Boolean use_Ib_flows = momentumDynamics Types.Dynamics.SteadyState "= true to consider differences in flow of momentum through boundaries" annotation(Dialog(group="Advanced"), Evaluate=true); ```...

@aci31 Yes, I think you nailed it. The idea of the 1.5 in the term you corrected is right in the sense that the length is 1.5, but the issue...

I investigated pretty thoroughly and issued a PR with the fix discussed. It seems to fully address the enthalpy balance when the kinetic energy term is turned off. However, after...

Update: the PR has been updated to resolve the remaining issues. Additionally, I would comment that some of the previous commentary and proposed solutions for the a_vb and av_b cases...

@henrikt-ma For pi and other unit="1" items: if you think it's prudent to wait then that seems reasonable. I will just say I hope/expect I should be able to catch...

@MartinOtter @AHaumer Any additional concerns here? Or can we approve and merge?

`i3` is not declared in your model, can you fix/clarify.

I wouldn't mind implementing this one, but I am unsure where in the code this change would be exactly. I can make the calculations by hand. For example, if this...