Dalton Messmer
Dalton Messmer
@szeli1 In the future could you please merge master into your branches rather than rebasing on master? Once you open a PR and people start reviewing it, rebasing makes it...
@bratpeki Sounds good to me. I think this PR is fine code-wise.
Support for multi-channel plugins has been implemented in #7459. I went with @michaelgregorius's suggestion and created a "Pin Connector" based on the one from REAPER. It required rewriting all of...
If we want to keep the "W/D" label, maybe it could be placed to the side of the knob and rotated 90 degrees? It shouldn't impact the vertical height that...
@JohannesLorenz The changes I made to `SampleFrame` don't affect any of its parameter or return value types. `InterleavedAudioDataPtr` is just an alias for `sample_t*`, so that class wasn't redesigned in...
@sakertooth About `SampleFrame`, I think there's been some talk before about removing `SampleFrame` and using non-interleaved buffers wherever possible, though if we did ever decide to do that, it would...
> Are you planning to make the *Impl functions private in a future PR? Just did it in this PR
Quick update For the past week I've been working ahead on some follow-up PRs for after this PR is merged, such as [multi-channel support for Carla](https://github.com/messmerd/lmms/tree/carla-multi-channel) (including audio port configurations...
It looks like the RMS out sum calculation for effects which return `ProcessStatus::ContinueIfNotQuiet` is currently being done on the track channels after the plugin finishes processing, but it should be...
@RainbowShatter Yes, that VST's sidechain inputs are usable with this PR, though we don't have audio routing yet so you probably won't be able to route the signal you want...