merusso

Results 16 comments of merusso

Thanks, @jcmoraisjr! The context you provided is greatly appreciated 😄

/remove-lifecycle stale We're using cert-manager with [Kong Ingress Controller](https://docs.konghq.com/kubernetes-ingress-controller/2.5.x/) and rely upon the ingress class being set correctly. Once PR #4439 was reverted, this broke our setup. It appears that...

I recently set up mTLS egress with Istio and worked through a number of issues before settling on the pattern described here: https://istio.io/latest/docs/tasks/traffic-management/egress/egress-tls-origination/#mutual-tls-origination-for-egress-traffic This config does *not* use an egress...

Storing a symmetric encryption key in the keyring should be more secure than storing it in a file. It would be better secured against physical access as the keyring's contents...

Personally, I'd love it if this feature would use the system's default browser instead of downloading a playwright browser, if that's possible (#729).

> Cross-linking my comment on the relevant PR: [#816 (comment)](https://github.com/Versent/saml2aws/pull/816#issuecomment-1174781406) > > This feature would allow `saml2aws` to work flawlessly on NixOS/other non-FHS linux distributions, which are broken at the...

> Hi, I would like to push this PR because it would allow NixOS users like me to use the Browser provider. In NixOS you cannot simply download a random...

Does this implementation allow use of an system's existing, default browser (#729)? It seems like it enables use of other Playwright browsers, which are still managed separately.

@gliptak I believe this was already created, #729. I believe the issue was mistakenly closed when this PR was merged.

In my opinion, using the system's default browser makes more sense than downloading/caching a new browser binary for login.