Mert

Results 543 comments of Mert

I think this might be a quirk of ZFS since everything is on a separate dataset. We only look at the library folder to get disk usage info, so in...

> I'm assuming that it's calculated from the meta in Immich rather than from storage This is right. Usage is stored in the DB and updated when assets are added...

This function is used in other parts of the codebase, so I'll have to check if this would cause any side effects.

Some of the server's asset repository methods also have stack relations and need to be updated to reflect the change. I don't like how the ordering is handled in the...

This is the query: https://github.com/immich-app/immich/blob/23b12565925634b35ecee246919d5ed6414178ab/mobile/lib/repositories/asset.repository.dart#L202

Nice! Once the asset repo queries are updated, this PR should be good to go.

So for example, `getByIds` in the asset repository can return the stacked assets for each asset. I'm not sure which of those calls are for API responses and which are...

In the example I shared with the `exif` and `assets` tables both having 2 million rows (one-one), using `LEFT JOIN LATERAL ... ON true` took at least 60s - I...

> How about `inner join on true`? Isn't that 100% equivalent to cross join? Nice suggestion! This one does have the same query plan and performance as cross join.

The spacing above and below PEOPLE changes when the search bar appears / disappears, making it a bit jarring. Can you make it so the search bar doesn't move anything?