Dmitry Merkushin

Results 28 comments of Dmitry Merkushin

@m1r0 Please, take a look - I've updated it eventually :)

> Should we move the installer classes to the internal namespace? Oh, that's hard :) Do you think we'll change its API in the near future?

@m1r0 we need to decide whether Installer is part of the internal API for now or not :) I was thinking about that a bit more: I don't see a...

@m1r0 I've updated the PR: moved Installer into the Internal namespace and added the `@internal` annotation.

Fixed here: https://github.com/Automattic/sensei/issues/6978

Thank for your review @renatho! I'll test it in a fresh environment to check the issues with the lesson order and the course opening. For the question category, I'll create...

@renatho > I realized that when duplicating the course, it created the lessons in the reverse order. In my test in the other PR I tried to order the lessons...

@renatho I've fixed the lesson order for "translated" lessons here: https://github.com/Automattic/sensei/pull/7480/commits/14466619dfd275a029db733ea4dde4eac36fbaa0 I had implemented the order inside modules, and probably decided later it works for other lessons 🙈 Could you...

@donnapep is this draft abandoned?