sensei icon indicating copy to clipboard operation
sensei copied to clipboard

Preserve status when emails are re-created

Open donnapep opened this issue 1 year ago • 3 comments

Resolves #6893.

Proposed Changes

  • Preserve the existing status of emails when they are re-created.
  • Also changes "recreate" (incorrect) to "re-create" (correct).

Testing Instructions

  1. Disable some of the emails and enable others.
  2. Re-create the emails from Sensei > Tools.
  3. Check to ensure that the status of every email is preserved.

Pre-Merge Checklist

  • [ ] PR title and description contain sufficient detail and accurately describe the changes
  • [ ] Acceptance criteria is met
  • [ ] Decisions are publicly documented
  • [ ] Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • [ ] All strings are translatable (without concatenation, handles plurals)
  • [ ] Follows our naming conventions (P6rkRX-4oA-p2)
  • [ ] Hooks (p6rkRX-1uS-p2) and functions are documented
  • [ ] New UIs are responsive and use a mobile-first approach
  • [ ] New UIs match the designs
  • [ ] Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • [ ] Code is tested on the minimum supported PHP and WordPress versions
  • [ ] User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • [ ] "Needs Documentation" label is added if this change requires updates to documentation
  • [ ] Known issues are created as new GitHub issues

donnapep avatar May 19 '23 19:05 donnapep

@donnapep is this draft abandoned?

merkushin avatar Jul 02 '23 13:07 merkushin

@merkushin Nope, I didn't have time to finish it on my janitorial rotation. It would be great if a janitor could pick it up. 🙂 I think it just needs tests maybe?

donnapep avatar Jul 03 '23 12:07 donnapep

Feel free to take over this PR.

donnapep avatar Feb 21 '24 17:02 donnapep